libimage.NormalizePlatform: normalize default variant as per specified arch
#1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flouthoc
force-pushed
the
normalize-platform-first
branch
from
629bcfb to
27fb4af
Compare
vrothberg
reviewed
Sep 28, 2022
nalind
reviewed
Sep 28, 2022
|
LGTM |
…d arch
As of now NormalizePlatform ignores normalizing or setting default
variants for specific arch types thus producing empty variants in
results even when default variants were expected for such cases.
Example consider: `linux/armhf` -> `{os:linux, arch: arm, variant: v7}`
Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
normalize-platform-first
branch
from
27fb4af to
764a413
Compare
|
I'll just open a dummy PR against podman for sanity check and then undraft this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following PR attempts to unify code being using in buildah and other part, so a common code chunk can be used as a source of truth for normalizing platforms.
As of now NormalizePlatform ignores normalizing or setting default variants for specific arch types thus producing empty variants in results even when default variants were expected for such cases.
Example consider:
linux/armhf->{os:linux, arch: arm, variant: v7}See: containers/buildah#4286 for more details.