util, GetRuntimeDir: don't error out early if XDG_RUNTIME_DIR is not set.
#1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…found We must try out all possible alternatives for rootless users instead of failing eary if XDG_RUNTIME_DIR is not set. Following regression was part of: containers@48f90f5 [NO NEW TESTS NEEDED] [NO TESTS NEEDED] Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
fix-regression
branch
from
d00d218 to
9bd5c94
Compare
|
LGTM |
|
/approve |
|
@rhatdan @giuseppe @vrothberg Merge me plz downstream PR's are green containers/podman#15987 and containers/buildah#4286 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Followup: today's cron treadmill (buildah) shows that this has indeed fixed the XDG-crashing bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must try out all possible alternatives for rootless users instead of failing eary if
XDG_RUNTIME_DIRis not set.Commit which introduced regression: 48f90f5
[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]