GHA: Limit operations to main branch only
#1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to it's design, github-actions workflows source their configuration from different locations depending on the event-type. This is impossible for humans to manage, let alone on repos with multiple release-branches. One would need to: 1. Understand the config-source for all utilized trigger events. 2. Ensure upon creation of a new branch or tag, the relevant source is updated to support reliable long-term operations. 3. Repeat for infinity. Fix this by removing all GHA trigger events except `pull_request`. For all pull requests, only trigger code validation if the target is `main`. Also, for `push` (merge) events, limit validation to `main` to prevent (new) validate from trying to run against (old) release branches - it will fail. Signed-off-by: Chris Evich <cevich@redhat.com>
This was referenced Oct 6, 2022
Merged
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to it's design, github-actions workflows source their configuration from different locations depending on the event-type. This is impossible for humans to manage, let alone on repos with multiple release-branches. One would need to:
Fix this by removing all GHA trigger events except
pull_request. For all pull requests, only trigger code validation if the target ismain.Also, for
push(merge) events, limit validation tomainto prevent (new) validate from trying to run against (old) release branches - it will fail.