Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty system context when copy image from oci-archive transport #1181

Merged

Conversation

tyler92
Copy link
Contributor

@tyler92 tyler92 commented Oct 10, 2022

Images runtime used the OCI archive transport with an empty system context, so such environment variables from user like TMDDIR were ignored.

Before this fix Podman used "/var/tmp" even if TMPDIR is set by user while using podman load with oci-archive transport.

$ podman save -o image.tar docker.io/library/debian:latest
$ TMPDIR=~/test/tmp podman --log-level=debug load -i ./image.tar | grep "/var/tmp"
DEBU[0000] Error loading ./image.tar (oci-archive): loading index: open /var/tmp/oci82198972/index.json: no such file or directory

Fixes: containers/podman#16104

Signed-off-by: Mikhail Khachayants tyler92@inbox.ru

Images runtime used the OCI archive transport with an empty system context,
so such environment variables from user like TMDDIR were ignored.

Signed-off-by: Mikhail Khachayants <tyler92@inbox.ru>
@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2022

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, tyler92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2022

@mheon PTAL
@vrothberg @mtrmac PTAL

@mheon
Copy link
Member

mheon commented Oct 10, 2022

Sure, LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 10, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit b0ee7e0 into containers:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TMPDIR is ignored while image is loading from oci-archive
4 participants