Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to golangci-lint v1.50.0 #1193

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

vrothberg
Copy link
Member

Used go fmt rules to migrate away from deprecated functions, for instance gofmt -w -s -r 'ioutil.TempDir(a, b) -> os.MkdirTemp(a, b)'

Signed-off-by: Valentin Rothberg vrothberg@redhat.com

Used `go fmt` rules to migrate away from deprecated functions, for
instance `gofmt -w -s -r 'ioutil.TempDir(a, b) -> os.MkdirTemp(a, b)'`

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg vrothberg marked this pull request as ready for review October 17, 2022 13:03
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 17, 2022

/lgtm
/hold

@rhatdan
Copy link
Member

rhatdan commented Oct 17, 2022

/hold cancel

1 similar comment
@rhatdan
Copy link
Member

rhatdan commented Oct 17, 2022

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 98295c0 into containers:main Oct 17, 2022
@vrothberg vrothberg deleted the bump-golangci branch October 17, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants