Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for the youki OCI Runtime #1202

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

unknowndevQwQ
Copy link
Contributor

@unknowndevQwQ unknowndevQwQ commented Oct 22, 2022

Signed-off-by: unknowndevQwQ@github unknowndevQwQ@protonmail.com

@rhatdan
Copy link
Member

rhatdan commented Oct 24, 2022

You have to sign you PRs.

@unknowndevQwQ
Copy link
Contributor Author

You have to sign you PRs.

Sorry, I forgot.

@unknowndevQwQ
Copy link
Contributor Author

@rhatdan Can we merge now?

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 25, 2022

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 25, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, saschagrunert, unknowndevQwQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit c79c840 into containers:main Oct 25, 2022
@unknowndevQwQ unknowndevQwQ deleted the patch-1 branch October 25, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants