Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers.conf: add events_container_create_inspect_data #1243

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Nov 23, 2022

Add an option to create a more verbose container-create event which
includes a JSON payload with detailed information about the container.

Jira: https://issues.redhat.com/browse/RUN-1702
Signed-off-by: Valentin Rothberg vrothberg@redhat.com

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member Author

Will mark as ready for review after feedback on this PR and the Podman coutnerpart (#1243).

pkg/config/containers.conf Outdated Show resolved Hide resolved
pkg/config/config.go Outdated Show resolved Hide resolved
@vrothberg vrothberg changed the title containers.conf: add event_audit_container_create containers.conf: add events_container_create_inspect_data Nov 24, 2022
@vrothberg vrothberg force-pushed the RUN-1702 branch 2 times, most recently from 741c057 to 7c6115b Compare November 25, 2022 11:03
@vrothberg
Copy link
Member Author

@Luap99 PTanotherL

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing containers.conf docs

@rhatdan
Copy link
Member

rhatdan commented Nov 28, 2022

LGTM

Add an option to create a more verbose container-create event which
includes a JSON payload with detailed information about the container.

Jira: https://issues.redhat.com/browse/RUN-1702
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg vrothberg marked this pull request as ready for review November 28, 2022 12:02
@vrothberg
Copy link
Member Author

missing containers.conf docs

Added

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Luap99
Copy link
Member

Luap99 commented Nov 28, 2022

/lgtm
/hold

@vrothberg
Copy link
Member Author

/hold cancel

@openshift-merge-robot openshift-merge-robot merged commit 24d7820 into containers:main Nov 28, 2022
@vrothberg vrothberg deleted the RUN-1702 branch November 28, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants