libnetwork: extend API to support NetworkUpdate
#1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
force-pushed
the
network-dns-update-api
branch
2 times, most recently
from
094d3ef to
5c77d6c
Compare
|
@Luap99 PTAL |
Luap99
reviewed
Dec 1, 2022
flouthoc
force-pushed
the
network-dns-update-api
branch
2 times, most recently
from
03f9b1e to
ea17a7e
Compare
flouthoc
force-pushed
the
network-dns-update-api
branch
from
ea17a7e to
f714653
Compare
Luap99
reviewed
Dec 5, 2022
flouthoc
force-pushed
the
network-dns-update-api
branch
from
f714653 to
db42c65
Compare
|
Needs a rebase. |
flouthoc
force-pushed
the
network-dns-update-api
branch
2 times, most recently
from
f69f85c to
b62be2b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@containers/podman-maintainers PTAL |
New features in netavark/aardvark allows users to update network dns servers and all the containers attached to those networks uses updated resolvers. Following PR adds support in `libnetwork` to support * Add support for higher level `NetworkUpdate` API * Add support for `Update` exec call which can invoke netavark with a new update option added here: containers/netavark#503 Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
network-dns-update-api
branch
from
b62be2b to
403bec6
Compare
|
Weird network errors in CI |
|
@containers/podman-maintainers PTAL and merge. |
rhatdan
reviewed
Dec 7, 2022
| @@ -19,6 +20,65 @@ import ( | |||
| "github.com/containers/storage/pkg/stringid" | |||
| ) | |||
|
|
|||
| func sliceRemoveDuplicates(strList []string) []string { | |||
There was a problem hiding this comment.
This function might be more useful in pkg/util.
Not blocking
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New features in netavark/aardvark allows users to update network dns servers and all the containers attached to those networks uses updated resolvers.
Following PR adds support in
libnetworkto supportNetworkUpdateAPIUpdateexec call which can invoke netavark with a new update option added here: update: add support fornetavark updatecommand netavark#503