Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework default list of capabilities to minimal #1252

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Dec 4, 2022

This reverts commit 45b76f1.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

This reverts commit 45b76f1.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented Dec 5, 2022

Related PR: containers/podman#16733

@rhatdan rhatdan changed the title [WIP] Revert "Revert "Rework default list of capabilities to minimal"" Rework default list of capabilities to minimal Dec 6, 2022
@rhatdan
Copy link
Member Author

rhatdan commented Dec 6, 2022

@vrothberg @Luap99 PTAL
The Podman PR now passes.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The commit message is a bit short for a security change but the diff has a nice explanation :)

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented Dec 6, 2022

@giuseppe @Luap99 @flouthoc @mheon PTAL
@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Dec 6, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2022
@openshift-merge-robot openshift-merge-robot merged commit def2a56 into containers:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants