-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cirrus: Update CI VM images to F37 #1365
Conversation
unhappy tests. |
Probably a flake. I restarted. @Luap99 FYI |
Not a flake, this is a test bug. Looks like we used an older netavark here, it used to ignore this error now it returns it correctly which triggers the test bug. @cevich please apply this: diff --git a/libnetwork/netavark/run_test.go b/libnetwork/netavark/run_test.go
index 5b950078..f75f70b9 100644
--- a/libnetwork/netavark/run_test.go
+++ b/libnetwork/netavark/run_test.go
@@ -302,7 +302,7 @@ var _ = Describe("run netavark", func() {
err = libpodNet.Teardown(netNSContainer.Path(), types.TeardownOptions(setupOpts1))
Expect(err).ToNot(HaveOccurred())
- err = libpodNet.Teardown(netNSContainer.Path(), types.TeardownOptions(setupOpts2))
+ err = libpodNet.Teardown(netNSContainer2.Path(), types.TeardownOptions(setupOpts2))
Expect(err).ToNot(HaveOccurred())
})
}) |
Thanks to @Luap99 for the test fix. Signed-off-by: Chris Evich <cevich@redhat.com>
0e6c667
to
e50941a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
/lgtm |
Ref: containers/automation_images#261