Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Update CI VM images to F37 #1365

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented Mar 14, 2023

@cevich cevich marked this pull request as draft March 14, 2023 21:17
@cevich
Copy link
Member Author

cevich commented Mar 14, 2023

unhappy tests.

@vrothberg
Copy link
Member

• [FAILED] [0.374 seconds]
run netavark [It] setup two containers
/var/tmp/go/src/github.com/containers/common/libnetwork/netavark/run_test.go:256
[FAILED] Unexpected error:
<*netavark.netavarkError | 0xc0004f71a0>: {
exitCode: 1,
Msg: "failed to delete container veth eth0: Netlink error: No such device (os error 19)",
err: nil,
}
netavark (exit code 1): failed to delete container veth eth0: Netlink error: No such device (os error 19)
occurred
In [It] at: /var/tmp/go/src/github.com/containers/common/libnetwork/netavark/run_test.go:306 @ 03/14/23 16:14:17.153

Probably a flake. I restarted. @Luap99 FYI

@Luap99
Copy link
Member

Luap99 commented Mar 15, 2023

• [FAILED] [0.374 seconds]
run netavark [It] setup two containers
/var/tmp/go/src/github.com/containers/common/libnetwork/netavark/run_test.go:256
[FAILED] Unexpected error:
<*netavark.netavarkError | 0xc0004f71a0>: {
exitCode: 1,
Msg: "failed to delete container veth eth0: Netlink error: No such device (os error 19)",
err: nil,
}
netavark (exit code 1): failed to delete container veth eth0: Netlink error: No such device (os error 19)
occurred
In [It] at: /var/tmp/go/src/github.com/containers/common/libnetwork/netavark/run_test.go:306 @ 03/14/23 16:14:17.153

Probably a flake. I restarted. @Luap99 FYI

Not a flake, this is a test bug. Looks like we used an older netavark here, it used to ignore this error now it returns it correctly which triggers the test bug.

@cevich please apply this:

diff --git a/libnetwork/netavark/run_test.go b/libnetwork/netavark/run_test.go
index 5b950078..f75f70b9 100644
--- a/libnetwork/netavark/run_test.go
+++ b/libnetwork/netavark/run_test.go
@@ -302,7 +302,7 @@ var _ = Describe("run netavark", func() {
 
                        err = libpodNet.Teardown(netNSContainer.Path(), types.TeardownOptions(setupOpts1))
                        Expect(err).ToNot(HaveOccurred())
-                       err = libpodNet.Teardown(netNSContainer.Path(), types.TeardownOptions(setupOpts2))
+                       err = libpodNet.Teardown(netNSContainer2.Path(), types.TeardownOptions(setupOpts2))
                        Expect(err).ToNot(HaveOccurred())
                })
        })

Thanks to @Luap99 for the test fix.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich cevich force-pushed the update_ci_vm_images branch from 0e6c667 to e50941a Compare March 15, 2023 18:11
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2023

LGTM
@cevich merge when you are ready.

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 15, 2023
@cevich cevich marked this pull request as ready for review March 16, 2023 14:47
@cevich cevich merged commit 86712a6 into containers:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants