Add oom_score_adj to set default oom score adj #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vrothberg @giuseppe @TomSweeneyRedHat @mheon @containers/podman-maintainers PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
reviewed
Mar 15, 2023
pkg/config/config.go
Outdated
| @@ -184,6 +184,10 @@ type ContainersConfig struct { | |||
| // NoHosts tells container engine whether to create its own /etc/hosts | |||
| NoHosts bool `toml:"no_hosts,omitempty"` | |||
|
|
|||
| // OOMScoreAdj tunes the host's OOM preferences for containers | |||
| // (accepts values from -1000 to 1000). | |||
| OOMScoreAdj int `toml:"oom_score_adj,omitempty,omitzero"` | |||
There was a problem hiding this comment.
Suggested change
| OOMScoreAdj int `toml:"oom_score_adj,omitempty,omitzero"` | |
| OOMScoreAdj *int `toml:"oom_score_adj,omitempty,omitzero"` |
AFAICT 0 is a valid value, so we need a way to see a difference between value not set and set to 0 by a user.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@containers/podman-maintainers PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.