-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] containers.conf: database_backend #1422
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make it clear that users should run podman system reset
before switching? We shouldn't allow using both db's at once.
Switching back and forth doesn’t require a reset, so as long as we document
the CLI flag as well I don’t think it’s necessary to recommend system reset.
…On Mon, Apr 17, 2023 at 07:38 Paul Holzinger ***@***.***> wrote:
***@***.**** commented on this pull request.
Maybe make it clear that users should run podman system reset before
switching? We shouldn't allow using both db's at once.
—
Reply to this email directly, view it on GitHub
<#1422 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCHE7Z6PWCT74XOLNA3XBUTUJANCNFSM6AAAAAAXA6I4TM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think that's rather something Podman should do/decide on. Podman could error out when there's already an existing DB that doesn't match the user/config selection. |
Well sure it doesn't have to, changing the network backend never required it either. Also there is zero information about what podman actually stores in the db. I loose access to containers, pods and volumes. However images and networks are shared for both because these are not stored in the db. As a naive user this is very confusing.
Yes that is what I would prefer but it also boils down to: you should do a system reset before switching this config option. |
I think you can document what is different in the man page as well as containers.conf. |
And then recommend the reset to permanently make the changes. Or at lease remove all networks and containers. |
Let's just state that " |
I do not think we should document which data is being stored in the DB. That is an internal that IMO no user should let their workloads rely on. The bottom line should always be that users need to expect to lose all their data when switching the backend/run |
Fine document that without resetting the storage then the system will not work correctly and executing the podman system reset is the best option. |
Done, PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can you add |
Done, thanks! |
Document the `database_backend` option which has been added earlier but intentionally left undocumented to avoid the impression sqlite would be ready for prime-time. Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
merge me |
/lgtm |
Document the
database_backend
option which has been added earlier but intentionally left undocumented to avoid the impression sqlite would be ready for prime-time.@mheon @baude @giuseppe PTAL