Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libimage: recommend podman system check over reset #2094

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jul 23, 2024

podman system reset nukes everything which makes not a great suggestion. Now that we have the podman system check recommend that instead as it actually checks the storage for corruption and might be able to repair it.

This is important because as it turns out this warning can pop up even in totally normal circumstances as there is a race between image and layer listing[1]. And even if that get fixed the check command will be the better suggestion.

[1] containers/podman#23331

podman system reset nukes everything which makes not a great suggestion.
Now that we have the podman system check recommend that instead as it
actually checks the storage for corruption and might be able to repair
it.

This is important because as it turns out this warning can pop up even
in totally normal circumstances as there is a race between image and
layer listing[1]. And even if that get fixed the check command will be
the better suggestion.

[1] containers/podman#23331

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jul 23, 2024

LGTM
If podman system check finds corruption, does it recommend podman system reset?

@Luap99
Copy link
Member Author

Luap99 commented Jul 23, 2024

If podman system check finds corruption, does it recommend podman system reset?

I don't think so, but you should not need to wipe everything in this case, podman system check can be used to "repair".

Options:
  -f, --force          Remove inconsistent images and containers
  -m, --max duration   Maximum allowed age of unreferenced layers (default 24h0m0s)
  -q, --quick          Skip time-consuming checks. The default is to include time-consuming checks
  -r, --repair         Remove inconsistent images

@Luap99
Copy link
Member Author

Luap99 commented Jul 23, 2024

cc @nalind @mtrmac

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@openshift-ci openshift-ci bot added the lgtm label Jul 23, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6411b35 into containers:main Jul 23, 2024
14 checks passed
@Luap99 Luap99 deleted the layer-race branch July 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants