Export portions of Copier #2164
Conversation
To support artifact handling, we need to export some of the methods for copier. The Copy and Close method have been exported. In addition, a new constructor that is exported was created so we could introduce a different SystemContext for artifacts. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
force-pushed
the
exportCopierNew
branch
from
ee0aaa4 to
be0910d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Non-blocking: Should this be split into a separate subpackage ( #2161 (comment) )? That can be done at any later time in a separate PR.
|
/lgtm |
|
None of the review comments were actually resolved AFAICS? I can see good reasons for not acting of them, but I don’t see any benefit of not representing the decision correctly. |
|
For the record, this continues in #2173. |
To support artifact handling, we need to export some of the methods for copier. The Copy and Close method have been exported. In addition, a new constructor that is exported was created so we could introduce a different SystemContext for artifacts.