Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPM: use default seccomp.json profiles #2169

Merged
merged 1 commit into from
Sep 20, 2024
Merged

RPM: use default seccomp.json profiles #2169

merged 1 commit into from
Sep 20, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 20, 2024

keyctl is in ALLOW by default and socket should not always be ALLOW, per @giuseppe.

This change removes seccomp.json customizations and we'll use the distro's default seccomp profile.

@lsm5
RPM: use default seccomp.json profiles
eb817b2 
keyctl is in ALLOW by default and `socket` should not always be ALLOW,
per @giuseppe.

This change removes seccomp.json customizations and we'll use the
distro's default seccomp profile.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
@lsm5 lsm5 marked this pull request as ready for review September 20, 2024 10:48
@lsm5
Copy link
Member Author

lsm5 commented Sep 20, 2024

@jnovy @giuseppe @Luap99 @rhatdan @mtrmac PTAL.

giuseppe
giuseppe approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, lsm5

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Luap99
Luap99 reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I like to know the reason why this was added in the first place.

@lsm5
Copy link
Member Author

lsm5 commented Sep 20, 2024

LGTM, although I like to know the reason why this was added in the first place.

@jnovy mentioned it was originally added in the rhel 8.2 days because support was asking for it. And about 4 years ago, Dan added those to the skopeo package (back when it was skopeo-containers) , and it had stayed since.

@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 20, 2024
@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2024

I don't recall this, but seems right to me.

@openshift-merge-bot openshift-merge-bot bot merged commit ff6611a into containers:main Sep 20, 2024
16 checks passed
@lsm5 lsm5 deleted the rpm-config-customization-trim branch September 20, 2024 14:31
@lsm5
Copy link
Member Author

lsm5 commented Sep 20, 2024

/cherrypick v0.60

@lsm5
Copy link
Member Author

lsm5 commented Sep 20, 2024

cherrypick bot is being slow for whatever reason. @giuseppe do we want this to land in Fedora in the next v0.60 release if there's one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

@giuseppe giuseppe giuseppe approved these changes

Assignees

@rhatdan rhatdan

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsm5 @rhatdan @giuseppe @Luap99