Precisely determine the ID of a pulled image #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
precise-pull-id
branch
from
83708b1 to
9f5c6e5
Compare
mtrmac
force-pushed
the
precise-pull-id
branch
from
9f5c6e5 to
da3fcb8
Compare
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Nov 4, 2024
> go mod edit -replace github.com/containers/common=github.com/mtrmac/common@precise-pull-id Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
precise-pull-id
branch
from
da3fcb8 to
cdf35b8
Compare
mtrmac
added a commit
to mtrmac/libpod
that referenced
this pull request
Nov 4, 2024
> go mod edit -replace github.com/containers/common=github.com/mtrmac/common@precise-pull-id Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Closed
|
This was manually tested using containers/podman#24447 (comment) , and a Podman test is running in containers/podman#24462 . Please review. Cc: @Luap99 |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
precise-pull-id
branch
from
cdf35b8 to
3291fed
Compare
|
The c/image PR has been merged, this is ready for review. |
mtrmac
changed the title
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Does this fix the zstd:chunked id changing problem? |
|
No |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on unmerged containers/image#2609 and #2202 .Instead of computing the manifest digest of the pulled image and looking up an image by digest (which can have several matches with different contents when under attack), obtain the exact image ID directly, using a new c/image API.
Absolutely untested at this point.