Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SetCredentials and add verbose to loginopts #607

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Jun 7, 2021

@flouthoc flouthoc marked this pull request as draft June 7, 2021 18:42
@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 7, 2021

waiting for new release of https://github.com/containers/image/ to be merged with master first. As this PR uses commit from containers/image#1204

pkg/auth/cli.go Outdated Show resolved Hide resolved
pkg/auth/auth.go Outdated Show resolved Hide resolved
pkg/auth/auth.go Outdated Show resolved Hide resolved
pkg/auth/cli.go Outdated Show resolved Hide resolved
pkg/auth/cli.go Outdated Show resolved Hide resolved
@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 9, 2021

@mtrmac @rhatdan Resolved all comments , waiting for upstream image to update then will re-base this PR.

@rhatdan
Copy link
Member

rhatdan commented Jun 14, 2021

@flouthoc Any progress?

@flouthoc
Copy link
Collaborator Author

@rhatdan I am waiting for a new release of containers/image, then we can re-base this PR

@flouthoc
Copy link
Collaborator Author

@rhatdan Could you please cut a new release for containers/image it will be used by this PR and podman itself.

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, for the record.

@rhatdan
Copy link
Member

rhatdan commented Jun 15, 2021

@flouthoc
Copy link
Collaborator Author

@rhatdan waiting for dependabot to raise a PR here at containers/common or should i do it

@mtrmac
Copy link
Contributor

mtrmac commented Jun 15, 2021

An admin of this repo can probably trigger Dependabot via Insights/Dependecy Graph/Dependabot ; I can’t see that option. Other than that it is configured to run daily.

@flouthoc
Copy link
Collaborator Author

@mtrmac Cool I think lets wait for a day if dependabot doesnt kicks in i'll bump dependencies myself in different commit.

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
@flouthoc flouthoc requested a review from rhatdan June 16, 2021 08:41
@flouthoc
Copy link
Collaborator Author

@mtrmac @rhatdan Following pr is rebased and ready for review. We would also need a new release of containers/common so that we could propogate vendor to podman.

@rhatdan
Copy link
Member

rhatdan commented Jun 16, 2021

/approve
/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants