Support older linux headers #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to allow building the software on machines not having the MOUNT_ATTR_IDMAP macro in header "linux/mount.h". When that macro is not available, the dependency on struct mount_attr is also eliminated (which is good since both the macro and the struct were added to the kernel uapi virtually at the same time). With the changes in this commit, errors would be thrown at runtime when mounting the erofs image, but only if the idmap feature is used; this resembles the behavior when the "new mount API" is not detected. Signed-off-by: Rogerio Guerra Borin <rogerio.borin@toradex.com>
This is to allow building the software on machines not having the macro LOOP_CONFIGURE or the struct loop_config in header "linux/loop.h" (both of which added to the kernel uapi at the same time); the code snippet providing them was taken from package util-linux, source file "include/loopdev.h". Signed-off-by: Rogerio Guerra Borin <rogerio.borin@toradex.com>
|
This looks sane, but...do you mind trying out adding a suitably old build environment in the CI configuration too? Otherwise we're somewhat likely to break this again. You're effectively aiming to define e.g. "Ubuntu Focal" as a baseline. Should be pretty trivial to pull that as a container image and build there right? |
Sure! I'll do that. Thanks for the feedback. |
This is to ensure the software continues to build on (somewhat old) "Ubuntu Focal"-based distros. At the moment, package "libfsverity-dev" is not available on that distro, so make its installation optional. Signed-off-by: Rogerio Guerra Borin <rogerio.borin@toradex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to tackle #252, i.e. allowing the build when macros MOUNT_ATTR_IDMAP and LOOP_CONFIGURE along with related structures are not available in the user API of the Linux kernel.