-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop gcrypt dependency and use blake3 #1395
Conversation
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@@ -35,6 +35,8 @@ endif | |||
check_LIBRARIES = libcrun_testing.a | |||
|
|||
libcrun_SOURCES = src/libcrun/utils.c \ | |||
src/libcrun/blake3/blake3.c \ | |||
src/libcrun/blake3/blake3_portable.c \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be a good idea of having a path to sub-repo of blake3 here instead of actual files ? Then crun-repo can avoid maintaining these sources directly ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some manual changes to the file: https://github.com/containers/crun/pull/1395/files#diff-99e860d54e0b9d30b4f6ed5f4b08109392e8cb83c0746fdda67f33d50d29f1c7R12-R20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sounds good in that case.
LGTM |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Closes: https://issues.redhat.com/browse/RHEL-22011 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
6fffa06
to
8d96f08
Compare
ready to merge |
After add this patch, I get CPU 100% some time. how to debug to trace down which line cause this ? |
do you have a reproducer? I would suggest running under gdb and stopping the debugger while you hit the cpu running at 100% |
alternative to #1393