Drop gcrypt dependency and use blake3 #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
flouthoc
reviewed
Jan 19, 2024
| @@ -35,6 +35,8 @@ endif | |||
| check_LIBRARIES = libcrun_testing.a | |||
|
|
|||
| libcrun_SOURCES = src/libcrun/utils.c \ | |||
| src/libcrun/blake3/blake3.c \ | |||
| src/libcrun/blake3/blake3_portable.c \ | |||
There was a problem hiding this comment.
Would it be a good idea of having a path to sub-repo of blake3 here instead of actual files ? Then crun-repo can avoid maintaining these sources directly ?
There was a problem hiding this comment.
I made some manual changes to the file: https://github.com/containers/crun/pull/1395/files#diff-99e860d54e0b9d30b4f6ed5f4b08109392e8cb83c0746fdda67f33d50d29f1c7R12-R20
There was a problem hiding this comment.
Ah sounds good in that case.
|
LGTM |
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Closes: https://issues.redhat.com/browse/RHEL-22011 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
drop-gcrypt-dependency
branch
from
6fffa06
to
8d96f08
Compare
|
ready to merge |
|
After add this patch, I get CPU 100% some time. how to debug to trace down which line cause this ? |
|
do you have a reproducer? I would suggest running under gdb and stopping the debugger while you hit the cpu running at 100% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #1393