container: attempt chdir twice #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the chdir could fail if it is performed while running as "root in the user namespace" and the access to the working directory is controlled by an ACL to grant permission to the specified final UID:GID. Closes: containers#793 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
the exec entrypoint is growing out of control, so take the occasion to move to a separate function. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
I thought that runc has a similar issue. @debarshiray can you verify this also fails with runc, if so we should report it to @kolyshkin |
|
it did but we also updated to call chdir twice opencontainers/runc#2894 (so I hope it works with runc haha) |
Yes, thanks! I have checked that it does (using the scenario from #793). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the chdir could fail if it is performed while running as "root in the user namespace" and the access to the working directory is controlledby an ACL to grant permission to the specified final UID:GID.
Closes: #793
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com