Skip to content

Commit

Permalink
gha: Use 'make lint' instead of golangci-lint-action
Browse files Browse the repository at this point in the history
While golangci/golangci-lint-action is convenient to use, it has the
side-effect of always using the latest golangci-lint release, which can
introduce new failures at any time.
If we use `make lint`, the golangci-lint version we tested with will be
used, and we can control when to updated to newer golangci-lint version,
and address the new warnings.
For example, golangci-lint v1.60.2 introduces new checks for int
overflows, which I'd rather address at a later time.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
  • Loading branch information
cfergeau committed Aug 22, 2024
1 parent c53fec5 commit 1e25363
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
with:
go-version-file: 'go.mod'
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
run: make lint

0 comments on commit 1e25363

Please sign in to comment.