-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip checking if the manifest difest matches for docker-daemon source. Fixes #1049 #1050
base: main
Are you sure you want to change the base?
Skip checking if the manifest difest matches for docker-daemon source. Fixes #1049 #1050
Conversation
3db87e4
to
5273b28
Compare
Signed-off-by: Alvaro Iradier <airadier@gmail.com>
5273b28
to
926f91e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
We shouldn’t have exceptions like this in the code, it will be very difficult to trace back unexpected behavior to this condition.
My first guess is that .DockerReference
should just not return a value if it can’t return a working value, but I’ll need to take a closer look at how the method is used in callers of c/image (sadly it’s not very well-defined what the value is intended to be used for).
@mtrmac I am running into this issue as well (with For context, I am using skopeo to unpack docker images in OCI format, but need to use the docker daemon to pull the image, so I am using |
Changing the Alternatively, yes, a transport declaring that the digests from Either way that affects semantics in caller-visible ways, so we need to at least audit existing users in the github.com/containers ecosystem. |
example issue: Any workaround possible? |
@universam1 That seems completely unrelated to the |
As described in #1049, the manifest digest specified in the repo@sha256:digest won't match the digest calculated from the locally generated manifest when using docker-daemon source.
This fix skips the verification for docker-daemon source.