-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker resolver with support for redirects #1237
base: main
Are you sure you want to change the base?
Conversation
959902b
to
8ec8ac6
Compare
Authorizes the request in case the host is redirected, supporting at most 10 redirects. Inspired in the containerd's implementation for supporting redirects. containerd/containerd@b1d4140 Signed-off-by: Fabio Luz <fabio.luz@scarf.sh>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@mtrmac PTAL
Initial issue: containerd/containerd#5503
Just a note for now: This needs careful review/research, compare #645 (comment) . |
Is there any update on this? Let me know if you need any changes. |
@mtrmac PTAL |
@mtrmac what is going on with this PR? |
I am also wondering when this could be merged. AFAIK, all the other container registry clients handle redirects these days. |
Authorizes the request in case the host is redirected, supporting at most 10 redirects.
Inspired in the containerd's implementation for supporting redirects. containerd/containerd@b1d4140
Signed-off-by: Fabio Luz fabio.luz@scarf.sh