[release-5.29] blobinfocache: add function to delete the cache directory #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for: containers/podman#22825 Addresses: https://issues.redhat.com/browse/ACCELFIX-268 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com> Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Bump c/image as noted to create a version of c/image for Podman v4.9-rhel to address https://issues.redhat.com/browse/ACCELFIX-268 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
As the title says. Bump back to a dev version. Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
mtrmac
reviewed
Jul 27, 2024
There was a problem hiding this comment.
The PR, in isolation, LGTM.
- Adding a new API in a .Z stream is, formally, against the rules. *shrug*
- I’d probably want to forward-port it to all more recent stable branches, then, to avoid a regression. I can do that work after this merges
- RH private: https://issues.redhat.com/browse/ACCELFIX-268?focusedId=25211440&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-25211440
@TomSweeneyRedHat I’m not merging this right now to give the private comment a chance to be considered, but this is a LGTM; please hit the merge button whenever you think appropriate.
|
LGTM |
|
@mtrmac, you make a good point about the API change, but I think this is OK as we're adding a new function and not changing/editing any existing functions. I'm going to merge this through as based on my read from the customer side, they were very eager to get this fix into a RHEL 8 stream. I'll happily take up your offer to port this elsewhere, but if you're crunched with the zstd fun, let me know, and I'll do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for: containers/podman#22825
Addresses: https://issues.redhat.com/browse/ACCELFIX-268
This is for the noted accelerated customer fix, once merged, this will need to be vendored into Podman v4.9-rhel and further cherry-picking will need to go on there.