virtio/fs: Fix corrupted dirents due to trailing garbage #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asahilina
requested review from
crobinso,
mtjhrc,
slp and
tylerfanelli
as code owners
andy9a9
reviewed
Jun 2, 2024
The dirent name length is supposed to be the actual strlen() of the name, without any padding. SYS_getdents64, however, will pad the records it returns (for alignment, etc.) as well as NUL-terminate the name. This was causing dirents in the guest kernel to have spurious NUL padding treated as part of the name, which in turn was breaking getcwd() under some conditions (and probably other more subtle things). Signed-off-by: Asahi Lina <lina@asahilina.net>
|
Fixed the code formatting ^^ |
slp
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dirent name length is supposed to be the actual
strlen()of the name, without any padding.SYS_getdents64, however, will pad the records it returns (for alignment, etc.) as well as NUL-terminate the name.This was causing dirents in the guest kernel to have spurious NUL padding treated as part of the name, which in turn was breaking
getcwd()under some conditions (and probably other more subtle things).