hvf: support ARM PSCI SYSTEM_OFF #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djs55
requested review from
crobinso,
mtjhrc,
slp and
tylerfanelli
as code owners
dgageot
reviewed
Jun 7, 2024
src/hvf/src/lib.rs
Outdated
| @@ -389,7 +389,8 @@ impl<'a> HvfVcpu<'a> { | |||
| let ret = match val { | |||
| 0x8400_0000 => Some(2), | |||
| 0x8400_0006 => Some(2), | |||
| 0x8400_0009 => return Ok(VcpuExit::Shutdown), | |||
| 0x8400_0008 => return Ok(VcpuExit::Shutdown), // ARM Power State Coordination Interface SYSTEM_OFF | |||
| 0x8400_0009 => return Ok(VcpuExit::Shutdown), // ARM Power State Coorgination Interface SYSTEM_RESET | |||
There was a problem hiding this comment.
Thanks! I've pushed a fix
This is part of the ARM Power State Coordination Interface, see https://developer.arm.com/documentation/den0022/f/?lang=en There are 2 calls: 1 for "system off" and one for "system reset". Previously we supported only "system reset", add support for "system off" as well. I tested with a small Go `init` process which ran: ``` func main() { _ = syscall.Reboot(syscall.LINUX_REBOOT_CMD_POWER_OFF) } ``` Before the patch it would keep running. After this patch it powers off as expected. Signed-off-by: David Scott <dave@recoil.org>
|
Tested here with |
slp
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the ARM Power State Coordination Interface, see https://developer.arm.com/documentation/den0022/f/?lang=en
There are 2 calls: 1 for "system off" and one for "system reset". Previously we supported only "system reset", add support for "system off" as well.
I tested with a small Go
initprocess which ran:Before the patch it would keep running. After this patch it powers off as expected.