Remove contention on the Gic #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
remove-contention-gic
branch
from
e15cc13 to
2fc86db
Compare
And move it down to each vcpu Building the Linux Kernel: 7m21s -> 6:58s Building Wasmer: 3m13s -> 2m30s Signed-off-by: David Gageot <david.gageot@docker.com>
Signed-off-by: David Gageot <david.gageot@docker.com>
dgageot
force-pushed
the
remove-contention-gic
branch
from
2fc86db to
7b2bbe2
Compare
|
Hi! |
slp
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
LGTM, thanks!
@tylerfanelli could you please take another look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of locking a single Gic, we move the contention down to the vCPU level.
This gives us better performance for CPU bound tasks.
On a 8 cores M3: