Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins: add sgx-epc plugin. #156

Merged
merged 1 commit into from
Oct 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@ PLUGINS ?= \
nri-resource-policy-balloons \
nri-resource-policy-template \
nri-memory-qos \
nri-memtierd
nri-memtierd \
nri-sgx-epc

BINARIES ?= \
config-manager
Expand Down
22 changes: 22 additions & 0 deletions cmd/plugins/sgx-epc/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
ARG GO_VERSION=1.20

FROM golang:${GO_VERSION}-bullseye as builder

WORKDIR /go/builder

# Fetch go dependencies in a separate layer for caching
COPY go.mod go.sum ./
COPY pkg/topology/ pkg/topology/
RUN go mod download

# Build the nri-sgx-epc plugin.
COPY . .

RUN make clean
RUN make PLUGINS=nri-sgx-epc build-plugins-static

FROM gcr.io/distroless/static

COPY --from=builder /go/builder/build/bin/nri-sgx-epc /bin/nri-sgx-epc

ENTRYPOINT ["/bin/nri-sgx-epc", "-idx", "40"]
38 changes: 38 additions & 0 deletions cmd/plugins/sgx-epc/nri-sgx-epc-deployment.yaml.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
apiVersion: apps/v1
kind: DaemonSet
metadata:
labels:
app: nri-sgx-epc
name: nri-sgx-epc
namespace: kube-system
spec:
selector:
matchLabels:
app: nri-sgx-epc
template:
metadata:
labels:
app: nri-sgx-epc
spec:
nodeSelector:
kubernetes.io/os: "linux"
containers:
- name: nri-sgx-epc
command:
- nri-sgx-epc
- --idx
- "40"
image: IMAGE_PLACEHOLDER
imagePullPolicy: IfNotPresent
resources:
requests:
cpu: 25m
memory: 100Mi
volumeMounts:
- name: nri-sockets-vol
mountPath: /var/run/nri
volumes:
- name: nri-sockets-vol
hostPath:
path: /var/run/nri
type: DirectoryOrCreate
174 changes: 174 additions & 0 deletions cmd/plugins/sgx-epc/sgx-epc.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,174 @@
// Copyright The NRI Plugins Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package main

import (
"context"
"flag"
"fmt"
"strconv"
"strings"

"github.com/sirupsen/logrus"
"sigs.k8s.io/yaml"

"github.com/containerd/nri/pkg/api"
"github.com/containerd/nri/pkg/stub"
)

const (
// Base key for encrypted page cache limit annotations.
epcLimitKey = "epc-limit.nri.io"
)

var (
log *logrus.Logger
verbose bool
)

// our injector plugin
type plugin struct {
stub stub.Stub
}

// CreateContainer handles container creation requests.
func (p *plugin) CreateContainer(_ context.Context, pod *api.PodSandbox, container *api.Container) (*api.ContainerAdjustment, []*api.ContainerUpdate, error) {
name := containerName(pod, container)

if verbose {
dump("CreateContainer", "pod", pod, "container", container)
} else {
log.Infof("CreateContainer %s", name)
}

limit, err := parseEpcLimit(pod.Annotations, container.Name)
if err != nil {
log.Errorf("failed to parse SGX EPC limit annotation: %v", err)
return nil, nil, err
}

adjust := &api.ContainerAdjustment{}

if limit > 0 {
adjust.AddLinuxUnified("misc.max", "sgx_epc "+strconv.FormatUint(limit, 10))

if verbose {
dump(name, "ContainerAdjustment", adjust)
} else {
log.Infof("encrypted page cache limit adjusted to %d", limit)
}
} else {
log.Infof("no encrypted page cache limit annotations")
}

return adjust, nil, nil
}

func parseEpcLimit(annotations map[string]string, ctr string) (uint64, error) {
// check container-specific or pod-global SGX EPC annotation and parse it
for _, key := range []string{
epcLimitKey + "/container." + ctr,
epcLimitKey + "/pod",
epcLimitKey,
} {
if value, ok := annotations[key]; ok {
limit, err := strconv.ParseUint(value, 10, 64)
if err != nil {
return 0, fmt.Errorf("failed to parse annotation %s: %w", value, err)
}
return limit, nil
}
}

return 0, nil
}

// Construct a container name for log messages.
func containerName(pod *api.PodSandbox, container *api.Container) string {
if pod != nil {
return pod.Namespace + "/" + pod.Name + "/" + container.Name
}
return container.Name
}

// Dump one or more objects, with an optional global prefix and per-object tags.
func dump(args ...interface{}) {
var (
prefix string
idx int
)

if len(args)&0x1 == 1 {
prefix = args[0].(string)
idx++
}

for ; idx < len(args)-1; idx += 2 {
tag, obj := args[idx], args[idx+1]
msg, err := yaml.Marshal(obj)
if err != nil {
log.Infof("%s: %s: failed to dump object: %v", prefix, tag, err)
continue
}

if prefix != "" {
log.Infof("%s: %s:", prefix, tag)
for _, line := range strings.Split(strings.TrimSpace(string(msg)), "\n") {
log.Infof("%s: %s", prefix, line)
}
} else {
log.Infof("%s:", tag)
for _, line := range strings.Split(strings.TrimSpace(string(msg)), "\n") {
log.Infof(" %s", line)
}
}
}
}

func main() {
var (
pluginName string
pluginIdx string
opts []stub.Option
err error
)

log = logrus.StandardLogger()
log.SetFormatter(&logrus.TextFormatter{
PadLevelText: true,
})

flag.StringVar(&pluginName, "name", "", "plugin name to register to NRI")
flag.StringVar(&pluginIdx, "idx", "", "plugin index to register to NRI")
flag.BoolVar(&verbose, "verbose", false, "enable (more) verbose logging")
flag.Parse()

if pluginName != "" {
opts = append(opts, stub.WithPluginName(pluginName))
}
if pluginIdx != "" {
opts = append(opts, stub.WithPluginIdx(pluginIdx))
}

p := &plugin{}
if p.stub, err = stub.New(p, opts...); err != nil {
log.Fatalf("failed to create plugin stub: %v", err)
}

err = p.stub.Run(context.Background())
if err != nil {
log.Fatalf("plugin exited with error %v", err)
}
}
11 changes: 11 additions & 0 deletions deployment/helm/sgx-epc/Chart.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
apiVersion: v2
appVersion: unstable
description: |
The sgx-epc NRI plugin allows control over SGX encrypted page cache usage using the
cgroup v2 misc controller and pod annotations.
name: nri-sgx-epc
sources:
- https://github.com/containers/nri-plugins
home: https://github.com/containers/nri-plugins
type: application
version: v0.0.0
99 changes: 99 additions & 0 deletions deployment/helm/sgx-epc/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
# SGX EPC Limit Plugin

This chart deploys the sgx-epc Node Resource Interface (NRI) plugin. This plugin
can be used to set limits on the encrypted page cache usage of containers using
annotations and (a yet to be merged pull request to) the cgroup v2 misc controller.

## Prerequisites

- Kubernetes 1.24+
- Helm 3.0.0+
- Container runtime:
- containerD:
- At least [containerd 1.7.0](https://github.com/containerd/containerd/releases/tag/v1.7.0)
release version to use the NRI feature.

- Enable NRI feature by following [these](https://github.com/containerd/containerd/blob/main/docs/NRI.md#enabling-nri-support-in-containerd)
detailed instructions. You can optionally enable the NRI in containerd using the Helm chart
during the chart installation simply by setting the `nri.patchRuntimeConfig` parameter.
For instance,

```sh
helm install my-sgx-epc nri-plugins/nri-sgx-epc --set nri.patchRuntimeConfig=true --namespace kube-system
```

Enabling `nri.patchRuntimeConfig` creates an init container to turn on
NRI feature in containerd and only after that proceed the plugin installation.

- CRI-O
- At least [v1.26.0](https://github.com/cri-o/cri-o/releases/tag/v1.26.0) release version to
use the NRI feature
- Enable NRI feature by following [these](https://github.com/cri-o/cri-o/blob/main/docs/crio.conf.5.md#crionri-table) detailed instructions.
You can optionally enable the NRI in CRI-O using the Helm chart
during the chart installation simply by setting the `nri.patchRuntimeConfig` parameter.
For instance,

```sh
helm install my-sgx-epc nri-plugins/nri-sgx-epc --namespace kube-system --set nri.patchRuntimeConfig=true
```

## Installing the Chart

Path to the chart: `nri-sg-epc`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/nri-sg-epc/nri-sgx-epc


```sh
helm repo add nri-plugins https://containers.github.io/nri-plugins
helm install my-sgx-epc nri-plugins/nri-sgx-epc --namespace kube-system
```

The command above deploys sgx-epc NRI plugin on the Kubernetes cluster within the
`kube-system` namespace with default configuration. To customize the available parameters
as described in the [Configuration options]( #configuration-options) below, you have two
options: you can use the `--set` flag or create a custom values.yaml file and provide it
using the `-f` flag. For example:

```sh
# Install the sgx-epc plugin with custom values provided using the --set option
helm install my-sgx-epc nri-plugins/nri-sgx-epc --namespace kube-system --set nri.patchRuntimeConfig=true
```

```sh
# Install the sgx-epc plugin with custom values specified in a custom values.yaml file
cat <<EOF > myPath/values.yaml
nri:
patchRuntimeConfig: true

tolerations:
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
EOF

helm install my-sgx-epc nri-plugins/nri-sgx-epc --namespace kube-system -f myPath/values.yaml
```

## Uninstalling the Chart

To uninstall the sgx-epc plugin run the following command:

```sh
helm delete my-sgx-epc --namespace kube-system
```

## Configuration options

The tables below present an overview of the parameters available for users to customize with their own values,
along with the default values.

| Name | Default | Description |
| ------------------------ | ----------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- |
| `image.name` | [ghcr.io/containers/nri-plugins/nri-sgx-epc](https://ghcr.io/containers/nri-plugins/nri-sgx-epc) | container image name |
| `image.tag` | unstable | container image tag |
| `image.pullPolicy` | Always | image pull policy |
| `resources.cpu` | 25m | cpu resources for the Pod |
| `resources.memory` | 100Mi | memory qouta for the |
| `nri.patchRuntimeConfig` | false | enable NRI in containerd or CRI-O |
| `initImage.name` | [ghcr.io/containers/nri-plugins/config-manager](https://ghcr.io/containers/nri-plugins/config-manager) | init container image name |
| `initImage.tag` | unstable | init container image tag |
| `initImage.pullPolicy` | Always | init container image pull policy |
| `tolerations` | [] | specify taint toleration key, operator and effect |
16 changes: 16 additions & 0 deletions deployment/helm/sgx-epc/templates/_helpers.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{{/*
Common labels
*/}}
{{- define "sgx-epc.labels" -}}
helm.sh/chart: {{ .Chart.Name }}-{{ .Chart.Version }}
app.kubernetes.io/managed-by: {{ .Release.Service }}
{{ include "sgx-epc.selectorLabels" . }}
{{- end -}}

{{/*
Selector labels
*/}}
{{- define "sgx-epc.selectorLabels" -}}
app.kubernetes.io/name: nri-sgx-epc
app.kubernetes.io/instance: {{ .Release.Name }}
{{- end -}}
Loading