Helm chart configmap fixes and some YAML clean up #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our agent expects the configmap to be named as `nri-resource-policy-config.default`, whereas in the helm chart, we have been using different names, such as `nri-resource-policy-topology-aware-config`. In order for the configmap configuration data to take effect, we must rename it to match the agent's expectation. Additionally, there are no scenarios where two plugins can run on the same node with two different configmap names. Therefore, we can have a consistent and standard name for the configmaps of different policy. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com>
fmuyassarov
force-pushed
the
confimap-naming-helm
branch
from
68ad209
to
326f606
Compare
jukkar
approved these changes
Jun 29, 2023
klihub
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the name of the configMap that agents is expecting and also corrects the name of the configMap that used as a base for fallback config.