CI Fixes #79
Merged
CI Fixes #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Args are split on commas for `buildah manifest create --annotation` unless they are quoted. Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Makes the `build-container` job more similar to the `release-container` workflow. Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
The `build` job ensures that Podlet can be built for all supported platforms, Linux, Windows, and macOS. Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
In `Cli::file_path()`, `color_eyre::eyre::bail!()` is used to return an error on non-Unix platforms if the `podlet --unit-directory` option is used. The `eyre` import was removed, so this resulted in a compiler error before. Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Signed-off-by: Paul Nettleton <k9@k9withabone.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor fix for the
release-containerCI. Changed thebuild-containerCI job to hopefully catch any similar issues in the future.Added a
buildjob to the CI to ensure Podlet builds on all supported platforms: Linux, Windows, and macOS.Minor fix in
Cli::file_path()for non-Unix platforms (i.e. Windows).I'll merge this and publish Podlet v0.3.0 tomorrow unless someone raises an objection.