fix: change the way to distinguish between prod and dev environment #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change statically replaced condition (import.meta.env.PROD) with a runtime node process variable - fixes mainly e2e tests - fixes containers#1780 Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
odockal
requested review from
jeffmaury and
lstocchi
and removed request for
a team
|
I believe that test part will fail on #1908. |
odockal
changed the title
odockal
changed the title
odockal
changed the title
odockal
changed the title
benoitf
reviewed
Apr 4, 2023
| // in production mode, use the extensions locally | ||
| folders = await this.readProductionFolders(path.join(__dirname, '../../../extensions')); | ||
| } else { | ||
| if (process.env.NODE_ENV && (process.env.NODE_ENV === 'development' || process.env.NODE_ENV === 'test')) { |
There was a problem hiding this comment.
I would prefer to not have these lines. I need to investigate to be able to use meta.env
because we've a lot of meta.env usage in Podman Desktop
|
closing as it was fixed by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the way how to distinguish between PROD and DEV environment when running e2e tests.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#1780
How to test this PR?
We just make sure to run e2e tests properly, when we distinguish between prod and dev environment. Some icons were not loaded properly when playwright tests were executed and so the app never loaded up.