Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fish completion not working as expected #8829

Closed
pastalian opened this issue Dec 24, 2020 · 3 comments · Fixed by #9079
Closed

Fish completion not working as expected #8829

pastalian opened this issue Dec 24, 2020 · 3 comments · Fixed by #9079
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@pastalian
Copy link

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Fish completion will not work if the command is prefixed with a space.

Steps to reproduce the issue:

  1. In fish shell, type <SPACE>podman<SPACE>

  2. Press TAB

Describe the results you received:

Fish shows file completion

❯  podman
bspwm_0_0-socket  fcitx-socket-:0  nvimgPYgkx/  tmux-1000/

Describe the results you expected:

Fish shows command completion

❯ podman
attach                                      (Attach to a running container)
auto-update  (Auto update containers according to their auto-update policy)
build               (Build an image using instructions from Containerfiles)
commit                    (Create new image based on the changed container)
…and 51 more rows

Additional information you deem important (e.g. issue happens only occasionally):

Output of podman version:

Version:      2.2.1
API Version:  2.1.0
Go Version:   go1.15.6
Git Commit:   a0d478edea7f775b7ce32f8eb1a01e75374486cb
Built:        Thu Dec 24 19:42:33 2020
OS/Arch:      linux/amd64

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide?

Yes

Additional environment details (AWS, VirtualBox, physical, etc.):

❯ fish --version
fish, version 3.1.2
@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 24, 2020
@rhatdan
Copy link
Member

rhatdan commented Dec 24, 2020

@Luap99 @edsantiago PTAL

@Luap99
Copy link
Member

Luap99 commented Dec 24, 2020

@pastalian Thanks for reaching out. Podman does not create the shell scripts they are auto generated by the spf13/cobra library. I will debug this and open a issue there.

@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

Luap99 added a commit to Luap99/libpod that referenced this issue Jan 24, 2021
Update the completion script like spf13/cobra#1249.

Fixes containers#8829

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
Luap99 added a commit to Luap99/libpod that referenced this issue Jan 24, 2021
Update the completion script like spf13/cobra#1249.

[NO TESTS NEEDED]

Fixes containers#8829

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
iwita pushed a commit to iwita/podman that referenced this issue Jan 26, 2021
Update the completion script like spf13/cobra#1249.

[NO TESTS NEEDED]

Fixes containers#8829

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants