Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump cobra to v1.2.1 and update the shell completion scripts #10852

Merged
merged 2 commits into from
Jul 3, 2021
Merged

bump cobra to v1.2.1 and update the shell completion scripts #10852

merged 2 commits into from
Jul 3, 2021

Commits on Jul 2, 2021

  1. Bump github.com/spf13/cobra to v1.2.1 

    Fixes containers#9730

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    @Luap99
    Luap99 committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    924cd37 View commit details
    Browse the repository at this point in the history

  2. update shell completion scripts 

    The new cobra v1.2.0 release brings a number of bug fixes for shell
completion scripts. Regenerate the scripts with `make completions`
to sync them with the upstream version, currently we have some custom
ones to avoid some upstream bugs. Because the new cobra version has
all fixes we should use the upstream scripts.
Add a check to CI to ensure we always use the up to date scripts.

[NO TESTS NEEDED]

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    @Luap99
    Luap99 committed Jul 2, 2021
    Configuration menu
    Copy the full SHA
    84da70a View commit details
    Browse the repository at this point in the history