volumes: add new option idmap #12298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
36a8b8a
to
3170904
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
giuseppe
added a commit
to giuseppe/common
that referenced
this pull request
Nov 15, 2021
needed by containers/podman#12298 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
c/common PR: containers/common#827 |
rhatdan
reviewed
Nov 15, 2021
pkg/util/mountOpts.go
Outdated
| @@ -33,6 +33,10 @@ func ProcessOptions(options []string, isTmpfs bool, sourcePath string) ([]string | |||
| // Some options have parameters - size, mode | |||
| splitOpt := strings.SplitN(opt, "=", 2) | |||
| switch splitOpt[0] { | |||
| case "idmap": | |||
| if len(options) > 1 { | |||
| return nil, errors.Wrapf(ErrDupeMntOption, "'idmap' option can not be used with other options") | |||
There was a problem hiding this comment.
I've copied the same logic as O.
I'll drop it
There was a problem hiding this comment.
I am just wondering if this would be an issue with Z, or RO?
There was a problem hiding this comment.
-v foo:/foo:idmap,Z seems to work fine
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
3170904
to
8eeb0bc
Compare
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
8eeb0bc
to
018805f
Compare
docs/source/markdown/podman-run.1.md
Outdated
| @@ -649,7 +651,9 @@ Current supported mount TYPEs are **bind**, **volume**, **image**, **tmpfs** and | |||
|
|
|||
| . relabel: shared, private. | |||
|
|
|||
| . U, chown: true or false (default). Change recursively the owner and group of the source volume based on the UID and GID of the container. | |||
| · idmap: true or false (default). If specified create an idmapped mount to the target user namespace in the container. | |||
There was a problem hiding this comment.
Suggested change
| · idmap: true or false (default). If specified create an idmapped mount to the target user namespace in the container. | |
| · idmap: true or false (default). If specified, create an idmapped mount to the target user namespace in the container. |
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
018805f
to
1bc19be
Compare
openshift-ci
bot
added
the
needs-rebase
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
1bc19be
to
a18624d
Compare
openshift-ci
bot
removed
the
needs-rebase
|
comments addressed and pushed a new version |
|
Tests are failing. |
pass down the "idmap" mount option to the OCI runtime. Needs: containers/crun#780 Closes: containers#12154 [NO NEW TESTS NEEDED] there is no crun version yet that support the new feature. Test case (must run as root): podman run --rm -v foo:/foo alpine touch /foo/bar podman run --uidmap 0:1:1000 --rm -v foo:/foo:idmap alpine ls -l /foo total 0 -rw-r--r-- 1 root root 0 Nov 15 14:01 bar Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
idmapped-bind-mounts
branch
from
a18624d
to
e83d366
Compare
|
rebased |
|
All green |
|
LGTM |
|
/lgtm |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pass down the "idmap" mount option to the OCI runtime.
Needs: containers/crun#780
Closes: #12154
[NO NEW TESTS NEEDED] there is no crun version yet that support the
new feature.
Test case (must run as root):
podman run --rm -v foo:/foo alpine touch /foo/bar
podman run --uidmap 0:1:1000 --rm -v foo:/foo:idmap alpine ls -l /foo
total 0
-rw-r--r-- 1 root root 0 Nov 15 14:01 bar
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com