[Never Merge] Verify parallel build race fix and new storage API

[flouthoc]

DO NOT MERGE

Verify race condition fix for parallel builds changes in deps.
Just to verify: https://github.com/containers/image/pull/1480/files & containers/storage#1153

Fixes issue for following reproducer

Reproducer

#!/bin/bash
x=1
sudo ./podman rmi -af
rm -f log*.*
sudo ./podman build -t first . &> logfirst.log
while [ $x -le 30 ]
do
  echo "$x times"
  sudo ./podman build --log-level debug -t $x . &> log$x.log &
  x=$(( $x + 1 ))
#  sleep 1
done

Dockerfile

FROM quay.io/jitesoft/alpine

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [flouthoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[TomSweeneyRedHat]

Looks like happy tests @flouthoc ! For the final, it would be nice to add a test similar to the reproducer.

[flouthoc]

Looks like happy tests @flouthoc ! For the final, it would be nice to add a test similar to the reproducer.

Thanks @TomSweeneyRedHat added a test for this as well.

[flouthoc]

@containers/storage-maintainers PTAL but following PR is just to verify not to merge

[vrothberg]

Once the c/storage PR is merged, we also need to open a PR against c/common and to migrate Tag/Untag.

[flouthoc]

@vrothberg Yes I agree. For parallel build issue we only need containers/image#1480 and containers/storage#1153 so should we drive this change slowly.

[vrothberg]

Since we know that SetNames is broken (and is soon deprecated), we should update all callers rather sooner than later. It's easy to forget about things on the TODO list.

[openshift-ci]

@flouthoc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vrothberg]

@flouthoc is this PR still needed?

[flouthoc]

@vrothberg Nope. Thanks for reminding.