Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use gopkg.in/yaml.v3 #14642

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Update to use gopkg.in/yaml.v3 #14642

merged 1 commit into from
Jun 21, 2022

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Jun 17, 2022

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member Author

rhatdan commented Jun 17, 2022

Also opened PR kubernetes-sigs/yaml#80
And need
ghodss/yaml#62 to be merged.

@Luap99
Copy link
Member

Luap99 commented Jun 17, 2022

Also opened PR kubernetes-sigs/yaml#80 And need ghodss/yaml#62 to be merged.

Note both packages are basically the same, if possible it would be good if we can just use one of them.

@rhatdan
Copy link
Member Author

rhatdan commented Jun 17, 2022

@Luap99 firstone to move to yaml.v3. :^)

@edsantiago
Copy link
Collaborator

LGTM

@rhatdan rhatdan added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2022
@openshift-ci openshift-ci bot merged commit 8d17251 into containers:main Jun 21, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants