runtime: parse conmon-rs version #15340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
giuseppe
force-pushed
the
conmon-rs-version-parse
branch
from
371a977 to
39b8330
Compare
|
changed to use the version from containers/common, but now we need containers/common#1121 before the original issue is addressed |
|
golang is mad 😢 |
giuseppe
force-pushed
the
conmon-rs-version-parse
branch
from
39b8330 to
4afc20e
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
conmon-rs-version-parse
branch
from
4afc20e to
91752f8
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
ready for review |
it detects conmon-rs. [NO NEW TESTS NEEDED] no functionalities added. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
conmon-rs-version-parse
branch
from
91752f8 to
20ad122
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detect the conmon-rs version string and if detected disable version
check for now.
Closes: #15335
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com
Does this PR introduce a user-facing change?