podman machine ssh handling #15471
Merged
podman machine ssh handling #15471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
cdoern
force-pushed
the
ssh
branch
2 times, most recently
from
d76d627 to
bf2331c
Compare
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
rhatdan
reviewed
Aug 29, 2022
vendor/github.com/containers/common/pkg/ssh/connection_golang.go
Outdated
Show resolved
Hide resolved
rhatdan
reviewed
Aug 29, 2022
vendor/github.com/containers/common/pkg/ssh/connection_golang.go
Outdated
Show resolved
Hide resolved
rhatdan
reviewed
Aug 29, 2022
vendor/github.com/containers/common/pkg/ssh/connection_golang.go
Outdated
Show resolved
Hide resolved
cdoern
force-pushed
the
ssh
branch
2 times, most recently
from
6ab47c0 to
9414a29
Compare
|
@containers/podman-maintainers this and its common counterpart are going to block any new releases PTAL |
|
@cdoern did you really mean to include all this new ginkgo stuff that's blowing up? |
@edsantiago , nope not sure where it is coming from either |
|
I think bringing a new c/common commit in is force upgrading gomega, and they recently made the change that is impacting this PR. I think if has to do with checking for two things in the same line. |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
ok, all of these are working which means the common changes are good to go. PTAL at containers/common#1136 |
cdoern
force-pushed
the
ssh
branch
2 times, most recently
from
64200ff to
6b5a432
Compare
mtrmac
reviewed
Sep 7, 2022
cdoern
force-pushed
the
ssh
branch
2 times, most recently
from
c9abda4 to
cdc3ddf
Compare
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdoern, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
mtrmac
reviewed
Sep 22, 2022
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
add the key used in newly initialized machines to the user's known_hosts file. This ensures that golang will be able to ssh into the machine using podman-remote. Also, remove the /dev/null redirection for podman machine ssh's known_hosts file. resolves containers#15347 Signed-off-by: Charlie Doern <cdoern@redhat.com> Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
|
/lgtm |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
sigh of relief |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the key used in newly initialized machines to the user's known_hosts file. This ensures that golang will be able to ssh into the machine using
podman-remote. Also, remove the /dev/null redirection for podman machine ssh's known_hosts file.
resolves #15347
Signed-off-by: Charlie Doern cdoern@redhat.com
Does this PR introduce a user-facing change?