build(deps): bump github.com/spf13/cobra from 1.5.0 to 1.6.0

[dependabot]

Bumps github.com/spf13/cobra from 1.5.0 to 1.6.0.

Release notes

Sourced from github.com/spf13/cobra's releases.

v1.6.0

Summer 2022 Release

Some exciting changes make their way to Cobra! Command completions continue to get better and better (including adding --help and --version automatic flags to the completions list). Grouping is now possible in your help output as well! And you can now use the OnFinalize method to cleanup things when all "work" is done. Checkout the full changelog below:

---

Features 🌠

• Add groups for commands in help: @​aawsome @​marckhouzam #1003
• Support for case-insensitive command names: @​YuviGold #1802
• Expose ValidateRequiredFlags and ValidateFlagGroups: @​skeetwu #1760
• Add --version flag to help output: @​fnickels #1707
• Add --help and --version flag in completions: @​marckhouzam #1813
• Add OnFinalize method: @​yann-soubeyrand #1788
• Allow user to add completion for powershell alias: @​marckhouzam #1621
• Make InitDefaultcompletionCmd public: @​gssbzn #1467

Deprecation 👎🏼

• ExactValidArgs is deprecated (but not being removed entirely). This is abit nuanced, so checkout #1643 for further information and the updated user_guide.md on how this may affect you (and how you can take advantage of the correct behavior in the validators): @​umarcor #1643

Bug fixes 🐛

• Fix (bash-v2) activeHelp length check syntax: @​scop #1762
• Fix correct command path in see_also for yaml documentation: @​zregvart #1771
• Fix showing flags that shadow parent persistent flag in child help messaging: @​brianpursley #1776

Dependencies 🗳️

• Upgrade to use gopkg.in/yaml.v3: @​tklauser #1766

Testing 🤔

• Test on Golang 1.19: @​umarcor & @​jpmcb #1782
• Renamed powershell completion tests: @​marckhouzam #1803
• Use action/setup-go cache: @​umarcor #1783
• Add workflow_dispatch to CI actions: @​umarcor #1387
• Add minimum GitHub token permissions for workflows: @​varunsh-coder #1792

Docs ✏️

• Fixup spelling for GitHub CLI: @​eltociear #1744
• Clarify SetContext documentation: @​katexochen #1748
• Instruct user to go install for binary: @​marckhouzam #1726
• User guide cleanup: @​marckhouzam #1656
• Document option to hide the default completion command: @​marckhouzam #1779

Misc 💭

• Add KubeVirt, CloudQuery, Cilium, Okteto, Zitadel, Allero to projects using cobra: @​maiqueb #1741, @​yevgenypats #1742, @​tklauser #1745, @​jLopezbarb #1759, @​fforootd #1772, @​dimabru #1819
• Use correct stale action exempt yaml keys: @​jpmcb #1800
• Add missing license headers: @​umarcor #1809

Note: Per #1804, we will be moving away from "seasonal" releases and doing more generic point release targets. Continue to track the milestones and issues in the spf13/cobra GitHub repository for more information!

Great work everyone! Cobra would never be possible without your contributions! 🐍

... (truncated)

Commits

• 8607918 feat: make InitDefaultCompletionCmd public (#1467)
• 2169adb Add groups for commands in help (#1003)
• 212ea40 Include --help and --version flag in completion (#1813)
• d4040ad Allow user to add completion for powershell alias (#1621)
• 23fc5e0 ci: add minimum GitHub token permissions for workflows (#1792)
• 93d1913 Add OnFinalize method (#1788)
• 07034fe build(deps): bump actions/stale from 5 to 6 (#1815)
• 3dc9761 Add allero to list of projects using cobra (#1819)
• 7039e1f Add '--version' flag to Help output (#1707)
• fce8d8a Expose ValidateRequiredFlags and ValidateFlagGroups (#1760)
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[rhatdan]

@Luap99 PTAL

[Luap99]

Interesting the new cobra version shows more options in the help output, however it looks like the new version is correct so we missed documenting some options.
cc @edsantiago

[edsantiago]

Oh.... interesting. I'd love to read your postmortem on this one.

[Luap99]

It is complaining about the the --namespace option in podman pod ps (before it only showed --ns which is the alias).

So now --help list the same flag twice:

$ bin/podman pod ps --help | grep namespace
      --namespace        Display namespace information of the pod
      --ns               Display namespace information of the pod

However what is super weird is that podman ps which uses the same flag name/setup code still only shows --ns???

[Luap99]

Correction, the flags are setup differently. podman pod ps defines the same flag twice instead of using an alias which is wrong.

We only see this now because cobra fixed an underlying bug: spf13/cobra#1776
--namespace already existed as global podman flag so it was not shown in the command specific help. Same for the other both flags --hooks-dir and --runtime-flag.

[Luap99]

This looks good now, can someone look at the buildah options please. I just copied them from buildah build so let me know if this is not correct.

[rhatdan]

/approve
/lgtm
/hold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dependabot[bot], rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhatdan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

LGTM
/hold cancel