Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] Document update for docker network options via CLI #17457

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[CI:DOCS] Document update for docker network options via CLI #17457

merged 1 commit into from
Feb 28, 2023

Conversation

hasan4791
Copy link
Contributor

@hasan4791 hasan4791 commented Feb 9, 2023 •
edited
Loading

Doc update to support docker-specific network create options via CLI

Closes: #15830

Signed-off-by: T K Chandra Hasan t.k.chandra.hasan@ibm.com

Does this PR introduce a user-facing change?

Yes

Support for following docker network options via CLI
1. com.docker.network.bridge.name
2. com.docker.network.driver.mtu

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2023

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Feb 9, 2023
@hasan4791 hasan4791 mentioned this pull request Feb 9, 2023
Merged
@hasan4791
Copy link
Contributor Author

hasan4791 commented Feb 21, 2023 •
edited
Loading

Waiting for the common dep version to be updated.
https://github.com/containers/common/releases/tag/v0.51.0

EDIT: Seems its has been updated to v0.51.1

@hasan4791 hasan4791 changed the title [WIP] [CI:DOCS] Document update for docker network options via CLI [CI:DOCS] Document update for docker network options via CLI Feb 21, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 21, 2023
@hasan4791
Doc update for docker network options via CLI
7f5fc04 
Doc update to support docker-specific network create options via CLI

Closes: containers#15830

Signed-off-by: T K Chandra Hasan <t.k.chandra.hasan@ibm.com>
@hasan4791
Copy link
Contributor Author

@rhatdan PTAL

@rhatdan
Copy link
Member

rhatdan commented Feb 22, 2023

LGTM
@Luap99 PTAL
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasan4791, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@TomSweeneyRedHat
Copy link
Member

LGTM
but would like a @Luap99 head nod

@Luap99
Copy link
Member

Luap99 commented Feb 27, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@hasan4791
Copy link
Contributor Author

Shall we merge this PR if all good :)

@rhatdan rhatdan removed the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Feb 28, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2023

yup

@openshift-merge-robot openshift-merge-robot merged commit db53f38 into containers:main Feb 28, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFE: Expose docker-specific network create options via the CLI
5 participants
@hasan4791 @rhatdan @TomSweeneyRedHat @Luap99 @openshift-merge-robot