Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add search --cert-dir, --creds #17463

Closed
wants to merge 0 commits into from

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Feb 10, 2023

When we searching any image at a container registry,
--cert-dir and --creds could be required
as well as push, pull, etc.

Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com

Does this PR introduce a user-facing change?

The podman search command now supports new options, --cert-dir, --creds.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note labels Feb 10, 2023
@sstosh
Copy link
Contributor Author

sstosh commented Feb 10, 2023

This commit contains changes to common/libimage.
Need to merge containers/common#1321 first.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Feb 10, 2023
@sstosh sstosh force-pushed the search-options branch 2 times, most recently from 158c302 to 0aea5e9 Compare February 10, 2023 13:21
@rhatdan
Copy link
Member

rhatdan commented Feb 14, 2023

Since this common was merged can you rebase this?

@sstosh sstosh force-pushed the search-options branch 2 times, most recently from 6f926d8 to eabc387 Compare February 14, 2023 05:40
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 16, 2023
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sstosh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions github-actions bot removed the kind/api-change Change to remote API; merits scrutiny label Feb 22, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants