-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency containers/automation_images to v20230405 #18124
Conversation
Signed-off-by: Renovate Bot <bot@renovateapp.com>
ed3871e
to
25bc7d1
Compare
@edsantiago FYI - this is the image-set you built that disables systemd-resolved. |
LGTM |
Leaving this here because I keep getting pulled off from tracking it down:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Restarted the flaked job.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: renovate[bot], vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I was about to scream loudly, saying something like "this is a new failure, let's try to understand it first because if it IS a flake it's going to hit us in production if we merge this". Fortunately, it's not a flake |
@edsantiago I guess this is a runc regression: opencontainers/runc#3620 I guess the reason why it passes rootless is because we load |
Looks like runc already removed net/tun device from the default list upstream: opencontainers/runc#3468 |
@cevich is it possible to side-update a renovatebot PR, or will this need to be done as a separate human-done PR? If the latter, I can try doing it. Suggested fix: diff --git a/contrib/cirrus/setup_environment.sh b/contrib/cirrus/setup_environment.sh
index 436024ef6..b24566e12 100755
--- a/contrib/cirrus/setup_environment.sh
+++ b/contrib/cirrus/setup_environment.sh
@@ -122,7 +122,12 @@ fi
# Which distribution are we testing on.
case "$OS_RELEASE_ID" in
- debian) ;;
+ debian)
+ # FIXME 2023-04-11: workaround for runc regression causing failure
+ # in system tests: "skipping device /dev/char/10:200 for systemd"
+ # FIXME: please remove this once runc >= 1.2 makes it into debian.
+ modprobe tun
+ ;;
fedora)
if ((CONTAINER==0)); then
# All SELinux distros need this for systemd-in-a-container |
@edsantiago you can just push to this branch |
Debian system tests failing due to unwanted warning: skipping device /dev/char/10:200 for systemd: stat /sys/dev/char/10:200: no such file or directory Let's see if modprobing tun will eliminate the warning. Add loud comments requesting removal once runc bug is fixed. Signed-off-by: Ed Santiago <santiago@redhat.com>
|
you have to push to |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
I restarted a bunch of tests which failed with:
Not sure if this is already tracked anywhere |
Ha. We get that so often that I added special-case code to my flake tracker for ignoring it. |
Cirrus timing:
@vrothberg as a side-channel followup to our current discussion in #15272: look at the two tests labeled "sys ... sqlite". Those are obviously not sqlite, because we do not test sqlite in system tests. So they're boltdb, so they should run in pretty much the same time as the test immediately above them ... but they're off by 90 seconds. That shows just plain normal variance between two otherwise identical test runs. It's not a precise science. |
/lgtm |
This PR contains the following updates:
20230307t192532z-f37f36d12
->20230405t152256z-f37f36d12
Release Notes
containers/automation_images
v20230405t152256z-f37f36d12
Compare Source
v20230330t153101z-f37f36d12
Compare Source
v20230320t154110z-f37f36d12
Compare Source
v20230314t204248z-f37f36d12
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.