-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP][CI:DOCS]Add DevContainers Documentation #18679
[WIP][CI:DOCS]Add DevContainers Documentation #18679
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jakecorrenti The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Basic use cases are reproducible. However, I need to iron out some edge cases with more complex use cases. |
} | ||
``` | ||
|
||
`Dockerfile` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming it has to be a Dockerfile vs a Containerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that Containerfile does work
Just a quick late day review, and it looks really good overall. It would be awesome of you could walk through this in a Gmeet, save the recording, then give me a ptr to it so I could put it up on the YouTube channel. |
I could definitely put that together for you |
Added documentation for setting up DevContainers in Visual Studio Code using Podman instead of Docker. Signed-off-by: Jake Correnti <jakecorrenti+github@proton.me>
37ff6f2
to
cd03732
Compare
I see the instructions are updated. I followed them, instead using my actual user name instead of $USER in the env variable. Now got further to this error message:
|
@fulldecent what Image did you select? And what does your |
@jakecorrenti I used the Ubuntu image. And here is the file // Documentation:
// - https://github.com/devcontainers/images/tree/main/src/jekyll
// - https://github.com/devcontainers/features/tree/main/src/node
// - https://github.com/devcontainers/features/tree/main/src/php
// Issue: how to remove the github.copilot dependency?
// https://stackoverflow.com/questions/76037936/how-to-load-github-copilot-without-specifying-in-devcontainer-json
{
"name": "Jekyll",
"image": "mcr.microsoft.com/devcontainers/jekyll",
"features": {
// Install latest stable Node (we use for validation scripts after build)
"ghcr.io/devcontainers/features/node:1": {
"version": "lts"
}
},
"customizations": {
"vscode": {
"extensions": ["github.copilot", "html-validate.vscode-html-validate"]
}
}
} |
Using the "features" functionality is known to lead to bugs (#17313). Investigating. |
A friendly reminder that this PR had no activity for 30 days. |
Closing the PR due to inactivity. Feel free to reopen. |
Added documentation for setting up DevContainers in Visual Studio Code using Podman instead of Docker.
Adapted from the work done in #15254
Does this PR introduce a user-facing change?