Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criu: return error when checking for min version #18857

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Jun 12, 2023

There is weird issue #18856 which causes the version check to fail. Return the underlying error in these cases so we can see it and debug it.

Does this PR introduce a user-facing change?

None

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Luap99
Copy link
Member Author

Luap99 commented Jun 12, 2023

@edsantiago PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 12, 2023
@edsantiago
Copy link
Member

I like the idea of handling errors, of course, but still hate the "CRIU is too old and I'm not going to tell you what version you have installed nyah nyah". Is there any way to rework the logic so the too-old message code does the comparison and can therefore display the current version?

@Luap99
Copy link
Member Author

Luap99 commented Jun 12, 2023

Sounds good, I think I can only return an error from this function then the caller just needs to do if err != nil and then inside this function I can create a proper error with the full context.

There is weird issue containers#18856 which causes the version check to fail.
Return the underlying error in these cases so we can see it and debug
it.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@edsantiago
Copy link
Member

Nice, thank you! LGTM.

@rhatdan
Copy link
Member

rhatdan commented Jun 12, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1e1efd8 into containers:main Jun 12, 2023
@Luap99 Luap99 deleted the criu-version-error branch June 12, 2023 16:06
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants