-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Run logformatter for podman_machine_windows_task #21991
CI: Run logformatter for podman_machine_windows_task #21991
Conversation
c26e30b
to
2a6b7a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, logs look much better with that
Write-Host "`nInstalling Perl as it is required to use logformatter" | ||
Run-Command 'choco install --no-progress --confirm --acceptlicense --nocolor StrawberryPerl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess that should be moved to our image builds: https://github.com/containers/automation_images/blob/a3e4099c72052ff21a6e538043cf05b5d873a110/win_images/win_packaging.ps1#L12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done but untested: containers/automation_images#337 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently we are checking if Perl exists before invoking logformatter and install it if necessary:
podman/contrib/cirrus/win-lib.ps1
Lines 43 to 50 in fb046fc
function Install-Perl-If-Required { | |
if (-not (Get-Command perl -ErrorAction SilentlyContinue)) { | |
Write-Host "`nInstalling Perl as it is required to use logformatter" | |
choco install --no-progress --confirm --acceptlicense --nocolor StrawberryPerl | |
Write-Host "`nAdd perl to the PATH" | |
Set-Item "Env:PATH" "$Env:PATH;C:\Strawberry\perl\bin" | |
} | |
} |
I will open another PR to remove this code as soon as Perl is available in the new windows image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2a6b7a1
to
b8ec448
Compare
New pasta (03-18). And, probably, lots more changes, some of which will break CI. Also: install StrawberryPerl on Windows, see: containers/podman#21991 (Note: debian crun 1.14.3 still does not exist. Grrr.) First CI-detected problem: debian: The following packages have unmet dependencies: debian: libfuse2t64 : Breaks: libfuse2 (< 2.9.9-8.1) Solution attempted: remove libfuse2 from INSTALL_PACKAGES Signed-off-by: Ed Santiago <santiago@redhat.com>
Thank you! I'm working on logformatter, adding code to recognize One request: could you find some way to inject Lines 632 to 636 in 8a643c2
...but of course that relies on an invocation of the form |
New pasta (03-19). And whatever else comes in. Also: install StrawberryPerl on Windows, see: containers/podman#21991 First CI-detected problem: debian: The following packages have unmet dependencies: debian: libfuse2t64 : Breaks: libfuse2 (< 2.9.9-8.1) Solution attempted: remove libfuse2 from INSTALL_PACKAGES Signed-off-by: Ed Santiago <santiago@redhat.com>
New pasta (03-19 and -20). And whatever else comes in. Also: install StrawberryPerl on Windows, see: containers/podman#21991 First CI-detected problem: debian: The following packages have unmet dependencies: debian: libfuse2t64 : Breaks: libfuse2 (< 2.9.9-8.1) Solution attempted: remove libfuse2 from INSTALL_PACKAGES And, bump expired Debian timebombs Signed-off-by: Ed Santiago <santiago@redhat.com>
New pasta (03-20). And whatever else comes in. Also: install StrawberryPerl on Windows, see: containers/podman#21991 First CI-detected problem: debian: The following packages have unmet dependencies: debian: libfuse2t64 : Breaks: libfuse2 (< 2.9.9-8.1) Solution attempted: remove libfuse2 from INSTALL_PACKAGES And, bump expired Debian timebombs Signed-off-by: Ed Santiago <santiago@redhat.com>
New pasta (03-20). And whatever else comes in. Also: install StrawberryPerl on Windows, see: containers/podman#21991 First CI-detected problem: debian: The following packages have unmet dependencies: debian: libfuse2t64 : Breaks: libfuse2 (< 2.9.9-8.1) Solution attempted: remove libfuse2 from INSTALL_PACKAGES And, bump expired Debian timebombs Signed-off-by: Ed Santiago <santiago@redhat.com>
4305e60
to
425148a
Compare
I have update the PR so that the html report is generated when tests fail too (this was tricky because there is no way to set Also now the reports first line has the git commit: Now the windows cirrus tasks install Perl if it's not installed yet. We can merge the PR as is or wait for the new VMs with Perl and remove the code that installs Perl from this PR. Tests failing examples: Tests passing examples: |
.cirrus.yml
Outdated
always: | ||
# Required for `contrib/cirrus/logformatter` to work properly | ||
html_artifacts: | ||
path: ./repo/*.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logs look great! Thank you! But this spurious /repo
breaks all existing conventions, and makes the logs impossible to find. Is there any way to remove the /repo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh. Doesn't look like there's a way to do that with Cirrus. Can the file be written (or moved) to ..
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ./repo/
folder is a peculiarity of the windows build (and it took some time to figure that out). I can have a look at the root cause of it. I would like to set ./repo
as the working directory to make it consistent with the other platforms. Otherwise I can move the html report up one folder when the log formatter terminates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without a 1-click link the formatted logs are not really very useful. However, it's still incremental progress and maybe other Windows peeps will want it.
Also, you might not know about this: https://github.com/edsantiago/greasemonkey/tree/master/github-ci-highlight In addition to colorizing github jobs in a way that makes patterns stand out, it also auto-links to colorized logs, adding a single-click trivial way to jump straight to logs. With the |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, l0rd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
810ac29
to
42b45c0
Compare
42b45c0
to
de3e1cd
Compare
containers#21760 Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
de3e1cd
to
c0e32e9
Compare
/lgtm |
Thanks for sharing. I was not aware of it. I made an update to the PR to move the report one folder up and now the link works. |
Confirmed, the link now works. Thank you! |
a77f705
into
containers:main
Followup to containers#21991. Strawberry Perl is now installed by default in CI VMs[1], so we no longer need the temporary install-perl code. [1] containers/automation_images#337 Signed-off-by: Ed Santiago <santiago@redhat.com>
Followup to containers#21991. Strawberry Perl is now installed by default in CI VMs[1], so we no longer need the temporary install-perl code. [1] containers/automation_images#337 Signed-off-by: Ed Santiago <santiago@redhat.com>
That's to address the windows part of #21760
Does this PR introduce a user-facing change?