Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Installer: bump wix to v5 #22408

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Commits on Jul 5, 2024

  1. Windows Installer: switch to wix5

    The chocolatey tool that was fetching us wix v3 can no longer be used to
    fetch wix v4+ so we had to switch to dotnet to fetch the latest wix.
    
    This commit builds the installer with wix v5.
    wix v5 is installed via the `dotnet` tool in the windows image itself
    at containers/automation_images#354.
    
    Going forward, the `dotnet` tool will also be used to build the installer.
    
    In the process, the wix v3 files were converted to wix v4+ using `wix
    convert` followed by manual modifications along with switch to wixproj
    builds with dotnet.
    
    The GitHub Action to upload windows installer now builds the installer
    using winmake.ps1.
    
    Contributions from Mario Loriedo:
    - bundle setup update to wix5
    - updates to build and release process scripts
    Ref: #3
    
    - small fixes to windows installer theme
    Ref: #4
    
    - Better win-installer sidebar logo
    Ref: #5
    
    Resolves: RUN-2055
    
    Co-authored-by: Mario Loriedo <mario.loriedo@gmail.com>
    Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
    lsm5 and l0rd committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    e2ff5d4 View commit details
    Browse the repository at this point in the history