Also substitute $HOME in runlabel with user's homedir #22529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
|
ignore el9 failures |
edsantiago
reviewed
Apr 29, 2024
dcermak
force-pushed
the
substitute-home-in-runlabel
branch
from
b15e15f
to
437628c
Compare
Luap99
reviewed
May 3, 2024
Some programs have their configuration files relative to the user's home. It would be convenient being able to mount these into the container, but that requires expansion of `~` or `$HOME` in a label. This commit adds support for that for the `runlabel` command. Signed-off-by: Dan Čermák <dcermak@suse.com>
dcermak
force-pushed
the
substitute-home-in-runlabel
branch
from
437628c
to
46f247d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcermak, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit f1b8439
into
containers:main
90 of 91 checks passed
stale-locking-app
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some programs have their configuration files relative to the user's home. It would be convenient being able to mount these into the container, but that requires expansion of
~or$HOMEin a label. This commit adds support for that for therunlabelcommand.Does this PR introduce a user-facing change?