Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return StatusNotFound when multiple volumes matching occurs #22715

Merged
merged 1 commit into from
May 16, 2024

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 15, 2024

Fixes #22616

Does this PR introduce a user-facing change?

None

Fixes containers#22616

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 15, 2024
@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label May 15, 2024
@openshift-ci openshift-ci bot added release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels May 15, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link

Cockpit tests failed for commit 6408a05. @martinpitt, @jelly, @mvollmer please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member Author

rhatdan commented May 16, 2024

@edsantiago PTAL
@mheon PTAL
@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented May 16, 2024

Good catch.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 31bfabf into containers:main May 16, 2024
90 of 93 checks passed
@rhatdan
Copy link
Member Author

rhatdan commented May 16, 2024

@edsantiago found the issue, I just found the cure.

@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 15, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

podman-remote volume rm ambiguous-name: unmarshalling error
3 participants