-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(build): improve err when file specified by -f does not exist #22972
Conversation
80d89b0
to
f7a3aa2
Compare
@mheon Modification completed, request re-review |
LGTM
…On Fri, Jun 14, 2024 at 05:43 Kevin Cui ***@***.***> wrote:
@mheon <https://github.com/mheon> Modification completed, request
re-review
—
Reply to this email directly, view it on GitHub
<#22972 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3AOCBET23OQYW2P2VDGOLZHJRGBAVCNFSM6AAAAABJFQKSL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGE2TIMBYGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
code lgtm, please consider a release note. |
please rebase |
do we have a test that uses -f for a non-existent file ? |
f7a3aa2
to
2252064
Compare
Done
I checked, and currently, there isn't one. Also, because this logic is within a large function, writing a unit test is quite difficult. Maybe we could add an e2e test? |
fb42330
to
ee124b0
Compare
Looks like some tests need to be fixed. |
05397b5
to
5897fdb
Compare
LGTM |
/approve |
code is fine, i did add a nit comment wondering if we can clean up readability ... will let @Luap99 break the tie. |
5897fdb
to
abea541
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
abea541
to
2096ea4
Compare
When the user specifies a Containerfile or Dockfile with the -f flag in podman build, if the file does not exist, the error should be intuitive to the user. Fixed: containers#22940 Signed-off-by: Kevin Cui <bh@bugs.cc>
2096ea4
to
3703cbf
Compare
Friendly ping :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BlackHole1, Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b3dab68
into
containers:main
When the user specifies a Containerfile or Dockfile with the -f flag in podman build, if the file does not exist, the error should be intuitive to the user.
Fixed: #22940
Does this PR introduce a user-facing change?