Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review corrections pass #2 #4953

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Review corrections pass #2 #4953

merged 1 commit into from
Jan 23, 2020

Conversation

baude
Copy link
Member

@baude baude commented Jan 23, 2020

Add API review comments to correct documentation and endpoints. Also, add a libpode prune method to reduce code duplication. Only used right now for the API but when the remote client is wired, we will switch over there too.

Signed-off-by: Brent Baude bbaude@redhat.com

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L labels Jan 23, 2020
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/container_commit.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/container_inspect.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/define/container.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/runtime_ctr.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/runtime_ctr.go Outdated Show resolved Hide resolved
mheon
mheon reviewed Jan 23, 2020
View reviewed changes
libpod/runtime_ctr.go Outdated Show resolved Hide resolved
@baude baude force-pushed the reviewcorrections2 branch 2 times, most recently from 6c0d7c5 to dd2b8b5 Compare January 23, 2020 16:32
jwhonce
jwhonce requested changes Jan 23, 2020
View reviewed changes
Copy link
Member

@jwhonce jwhonce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed.

pkg/api/handlers/containers.go Outdated Show resolved Hide resolved
pkg/api/handlers/generic/containers_create.go Show resolved Hide resolved
pkg/api/handlers/libpod/containers.go Outdated Show resolved Hide resolved
pkg/api/server/register_containers.go Show resolved Hide resolved
jwhonce
jwhonce reviewed Jan 23, 2020
View reviewed changes
pkg/api/handlers/generic/containers.go Outdated Show resolved Hide resolved
pkg/api/handlers/libpod/containers.go Outdated Show resolved Hide resolved
@baude
Review corrections pass #2
cf7be58 
Add API review comments to correct documentation and endpoints.  Also, add a libpode prune method to reduce code duplication.  Only used right now for the API but when the remote client is wired, we will switch over there too.

Signed-off-by: Brent Baude <bbaude@redhat.com>
@jwhonce
Copy link
Member

jwhonce commented Jan 23, 2020

/hold
/lgtm

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 23, 2020
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude, jwhonce

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member Author

baude commented Jan 23, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5bad873 into containers:master Jan 23, 2020
@rh-atomic-bot rh-atomic-bot mentioned this pull request Jan 23, 2020
Closed
@baude baude deleted the reviewcorrections2 branch May 18, 2022 15:22
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

@jwhonce jwhonce jwhonce approved these changes

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@jwhonce jwhonce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@baude @jwhonce @openshift-ci-robot @mheon @openshift-merge-robot